projects / platform / upstream / dotnet / runtime.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: fbced1b)
[iOS] Skip test suites that take too long to build on helix (#72849)
authorSteve Pfister <steveisok@users.noreply.github.com>
Wed, 27 Jul 2022 01:37:30 +0000 (18:37 -0700)
committerGitHub <noreply@github.com>
Wed, 27 Jul 2022 01:37:30 +0000 (21:37 -0400)
System.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB.  The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably.

Skipping these tests for now.

Addresses https://github.com/dotnet/runtime/issues/72834

Addresses https://github.com/dotnet/runtime/issues/72836

src/libraries/tests.proj patch | blob | history

diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj
index b259bb9..32b5919 100644 (file)
--- a/src/libraries/tests.proj
+++ b/src/libraries/tests.proj
@@ -286,11 +286,16 @@
     <!--
       Test apps that are too large and take too long to build 
       Keep here until aggressive trimming targets can work on helix.
+
+      https://github.com/dotnet/runtime/issues/72834
+      https://github.com/dotnet/runtime/issues/72836
     -->
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\UnitTests\System.Text.RegularExpressions.Tests.csproj" />
+    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj" />
+    <ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.Logging.Abstractions\tests\Microsoft.Extensions.Logging.Generators.Tests\Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj" />
+    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Unit.Tests\System.Text.Json.SourceGeneration.Roslyn4.0.Unit.Tests.csproj" />
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Tests\System.Text.Json.SourceGeneration.Roslyn4.0.Tests.csproj" />
 
-
     <!-- Functional tests on devices have problems with return codes from mlaunch -->
     <ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\$(TargetOS)\Device\**\*.Test.csproj" />
   </ItemGroup>
Domain: Dotnet / Core;