drm/amd/display: Clearly states if long or short HPD event in dmesg logs
authorStylon Wang <stylon.wang@amd.com>
Wed, 1 Mar 2023 15:56:51 +0000 (23:56 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 15 Mar 2023 22:45:26 +0000 (18:45 -0400)
[Why]
The log "DMUB HPD callback" is crucial to identify when DP tunneling
is been established and driver is notified of this event from DMUB.
Same log is shared for long and short hotplug event and we need to
check trailing DC debug log to distinguish between them two, making
debugging on DPIA related issues a bit more troublesome.

[How]
Clearly states in dmesg logs whether this is a long or short hotplug
event.

Reviewed-by: Hamza Mahfooz <Hamza.Mahfooz@amd.com>
Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Signed-off-by: Stylon Wang <stylon.wang@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index e0b7ef6..eeaeca8 100644 (file)
@@ -713,7 +713,14 @@ static void dmub_hpd_callback(struct amdgpu_device *adev,
        drm_for_each_connector_iter(connector, &iter) {
                aconnector = to_amdgpu_dm_connector(connector);
                if (link && aconnector->dc_link == link) {
-                       DRM_INFO("DMUB HPD callback: link_index=%u\n", link_index);
+                       if (notify->type == DMUB_NOTIFICATION_HPD)
+                               DRM_INFO("DMUB HPD callback: link_index=%u\n", link_index);
+                       else if (notify->type == DMUB_NOTIFICATION_HPD_IRQ)
+                               DRM_INFO("DMUB HPD IRQ callback: link_index=%u\n", link_index);
+                       else
+                               DRM_WARN("DMUB Unknown HPD callback type %d, link_index=%u\n",
+                                               notify->type, link_index);
+
                        hpd_aconnector = aconnector;
                        break;
                }