net: use eth_hw_addr_set() instead of ether_addr_copy()
authorJakub Kicinski <kuba@kernel.org>
Fri, 1 Oct 2021 21:32:22 +0000 (14:32 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Aug 2022 15:16:37 +0000 (17:16 +0200)
[ Upstream commit e35b8d7dbb094c79daf920797c372911edc2d525 ]

Convert from ether_addr_copy() to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - ether_addr_copy(dev->dev_addr, np)
  + eth_hw_addr_set(dev, np)

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ipvlan/ipvlan_main.c
drivers/net/macsec.c
drivers/net/macvlan.c
net/8021q/vlan_dev.c
net/dsa/slave.c
net/hsr/hsr_device.c
net/hsr/hsr_main.c

index c0b21a5..3f43c25 100644 (file)
@@ -787,7 +787,7 @@ static int ipvlan_device_event(struct notifier_block *unused,
 
        case NETDEV_CHANGEADDR:
                list_for_each_entry(ipvlan, &port->ipvlans, pnode) {
-                       ether_addr_copy(ipvlan->dev->dev_addr, dev->dev_addr);
+                       eth_hw_addr_set(ipvlan->dev, dev->dev_addr);
                        call_netdevice_notifiers(NETDEV_CHANGEADDR, ipvlan->dev);
                }
                break;
index 3548909..0a860cb 100644 (file)
@@ -3616,7 +3616,7 @@ static int macsec_set_mac_address(struct net_device *dev, void *p)
        dev_uc_del(real_dev, dev->dev_addr);
 
 out:
-       ether_addr_copy(dev->dev_addr, addr->sa_data);
+       eth_hw_addr_set(dev, addr->sa_data);
        macsec->secy.sci = dev_to_sci(dev, MACSEC_PORT_ES);
 
        /* If h/w offloading is available, propagate to the device */
index a9a515c..6363459 100644 (file)
@@ -711,7 +711,7 @@ static int macvlan_sync_address(struct net_device *dev, unsigned char *addr)
 
        if (!(dev->flags & IFF_UP)) {
                /* Just copy in the new address */
-               ether_addr_copy(dev->dev_addr, addr);
+               eth_hw_addr_set(dev, addr);
        } else {
                /* Rehash and update the device filters */
                if (macvlan_addr_busy(vlan->port, addr))
index 8602885..a54535c 100644 (file)
@@ -250,7 +250,7 @@ bool vlan_dev_inherit_address(struct net_device *dev,
        if (dev->addr_assign_type != NET_ADDR_STOLEN)
                return false;
 
-       ether_addr_copy(dev->dev_addr, real_dev->dev_addr);
+       eth_hw_addr_set(dev, real_dev->dev_addr);
        call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
        return true;
 }
@@ -349,7 +349,7 @@ static int vlan_dev_set_mac_address(struct net_device *dev, void *p)
                dev_uc_del(real_dev, dev->dev_addr);
 
 out:
-       ether_addr_copy(dev->dev_addr, addr->sa_data);
+       eth_hw_addr_set(dev, addr->sa_data);
        return 0;
 }
 
@@ -586,7 +586,7 @@ static int vlan_dev_init(struct net_device *dev)
        dev->dev_id = real_dev->dev_id;
 
        if (is_zero_ether_addr(dev->dev_addr)) {
-               ether_addr_copy(dev->dev_addr, real_dev->dev_addr);
+               eth_hw_addr_set(dev, real_dev->dev_addr);
                dev->addr_assign_type = NET_ADDR_STOLEN;
        }
        if (is_zero_ether_addr(dev->broadcast))
index a2bf2d8..11ec9e6 100644 (file)
@@ -174,7 +174,7 @@ static int dsa_slave_set_mac_address(struct net_device *dev, void *a)
                dev_uc_del(master, dev->dev_addr);
 
 out:
-       ether_addr_copy(dev->dev_addr, addr->sa_data);
+       eth_hw_addr_set(dev, addr->sa_data);
 
        return 0;
 }
@@ -1954,7 +1954,7 @@ int dsa_slave_create(struct dsa_port *port)
 
        slave_dev->ethtool_ops = &dsa_slave_ethtool_ops;
        if (!is_zero_ether_addr(port->mac))
-               ether_addr_copy(slave_dev->dev_addr, port->mac);
+               eth_hw_addr_set(slave_dev, port->mac);
        else
                eth_hw_addr_inherit(slave_dev, master);
        slave_dev->priv_flags |= IFF_NO_QUEUE;
index ea7b96e..a1045c3 100644 (file)
@@ -493,7 +493,7 @@ int hsr_dev_finalize(struct net_device *hsr_dev, struct net_device *slave[2],
        INIT_LIST_HEAD(&hsr->self_node_db);
        spin_lock_init(&hsr->list_lock);
 
-       ether_addr_copy(hsr_dev->dev_addr, slave[0]->dev_addr);
+       eth_hw_addr_set(hsr_dev, slave[0]->dev_addr);
 
        /* initialize protocol specific functions */
        if (protocol_version == PRP_V1) {
index f7e284f..b099c31 100644 (file)
@@ -75,7 +75,7 @@ static int hsr_netdev_notify(struct notifier_block *nb, unsigned long event,
                master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
 
                if (port->type == HSR_PT_SLAVE_A) {
-                       ether_addr_copy(master->dev->dev_addr, dev->dev_addr);
+                       eth_hw_addr_set(master->dev, dev->dev_addr);
                        call_netdevice_notifiers(NETDEV_CHANGEADDR,
                                                 master->dev);
                }