Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents
authorJunsuChoi <jsuya.choi@samsung.com>
Tue, 12 May 2020 15:20:21 +0000 (11:20 -0400)
committerJongmin Lee <jm105.lee@samsung.com>
Tue, 12 May 2020 21:52:15 +0000 (06:52 +0900)
Summary:
When call elm_check_add, theme_apply of layout is called and
_efl_ui_check_legacy_efl_ui_widget_theme_apply is called.
Then it calls the signal emit for the icon.
this call is unnecessary.

Test Plan: N/A

Reviewers: akanad, Jaehyun_Cho, Hermet, YOhoho, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11812

src/lib/elementary/efl_ui_check.c

index 6155f65..2002170 100644 (file)
@@ -484,7 +484,7 @@ _efl_ui_check_legacy_efl_ui_widget_theme_apply(Eo *obj, void *_pd EINA_UNUSED)
    int_ret = efl_ui_widget_theme_apply(efl_super(obj, EFL_UI_CHECK_LEGACY_CLASS));
    if (int_ret == EFL_UI_THEME_APPLY_ERROR_GENERIC) return int_ret;
 
-   _icon_signal_emit(obj);
+   if (efl_finalized_get(obj)) _icon_signal_emit(obj);
 
    return int_ret;
 }