projects
/
platform
/
upstream
/
mesa.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bf709df
)
turnip: Don't return from tu_stub funcs
author
Chad Versace
<chadversary@chromium.org>
Mon, 12 Nov 2018 22:45:47 +0000
(14:45 -0800)
committer
Chia-I Wu
<olvaffe@gmail.com>
Mon, 11 Mar 2019 17:01:41 +0000
(10:01 -0700)
Since the macros are lowercase and look like normal functions, that they
change control flow with a hidden return is surprising.
src/freedreno/vulkan/tu_private.h
patch
|
blob
|
history
diff --git
a/src/freedreno/vulkan/tu_private.h
b/src/freedreno/vulkan/tu_private.h
index
26a342f
..
d6271f3
100644
(file)
--- a/
src/freedreno/vulkan/tu_private.h
+++ b/
src/freedreno/vulkan/tu_private.h
@@
-262,16
+262,9
@@
tu_logi_v(const char *format, va_list va);
#define tu_use_args(...) __tu_use_args(0, ##__VA_ARGS__)
static inline void __tu_use_args(int ignore, ...) {}
-#define tu_stub_return(v) \
- do { \
- tu_finishme("stub %s", __func__); \
- return (v); \
- } while (0)
-
#define tu_stub() \
do { \
tu_finishme("stub %s", __func__); \
- return; \
} while (0)
void *