tty: n_tty: make n_tty_data::num_overrun unsigned
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Sun, 27 Aug 2023 07:41:38 +0000 (09:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 27 Aug 2023 09:46:52 +0000 (11:46 +0200)
n_tty_data::num_overrun is unlikely to overflow in a second. But make it
explicitly unsigned to avoid printing negative values.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230827074147.2287-6-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_tty.c

index c0b23e9..7f8f6cf 100644 (file)
@@ -99,7 +99,7 @@ struct n_tty_data {
 
        /* private to n_tty_receive_overrun (single-threaded) */
        unsigned long overrun_time;
-       int num_overrun;
+       unsigned int num_overrun;
 
        /* non-atomic */
        bool no_room;
@@ -1174,7 +1174,7 @@ static void n_tty_receive_overrun(const struct tty_struct *tty)
 
        ldata->num_overrun++;
        if (time_is_before_jiffies(ldata->overrun_time + HZ)) {
-               tty_warn(tty, "%d input overrun(s)\n", ldata->num_overrun);
+               tty_warn(tty, "%u input overrun(s)\n", ldata->num_overrun);
                ldata->overrun_time = jiffies;
                ldata->num_overrun = 0;
        }