floppy: fix usercopy direction

commit 52f6f9d74f31078964ca1574f7bb612da7877ac8 upstream.

As sparse points out, these two copy_from_user() should actually be
copy_to_user().

Fixes: 229b53c9bf4e ("take floppy compat ioctls to sodding floppy.c")
Cc: stable@vger.kernel.org
Acked-by: Alexander Popov <alex.popov@linux.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 4a9a4d1..e71589e 100644 (file)
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -3791,7 +3791,7 @@ static int compat_getdrvprm(int drive,
        v.native_format = UDP->native_format;
        mutex_unlock(&floppy_mutex);
 
-       if (copy_from_user(arg, &v, sizeof(struct compat_floppy_drive_params)))
+       if (copy_to_user(arg, &v, sizeof(struct compat_floppy_drive_params)))
                return -EFAULT;
        return 0;
 }
@@ -3827,7 +3827,7 @@ static int compat_getdrvstat(int drive, bool poll,
        v.bufblocks = UDRS->bufblocks;
        mutex_unlock(&floppy_mutex);
 
-       if (copy_from_user(arg, &v, sizeof(struct compat_floppy_drive_struct)))
+       if (copy_to_user(arg, &v, sizeof(struct compat_floppy_drive_struct)))
                return -EFAULT;
        return 0;
 Eintr: