remoteproc: qcom: Replace hard coded values with macros
authorSrinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Wed, 28 Sep 2022 12:27:51 +0000 (17:57 +0530)
committerBjorn Andersson <andersson@kernel.org>
Wed, 28 Dec 2022 16:29:34 +0000 (10:29 -0600)
Replace hard coded values of QDSP6 boot control reg params
with appropriate macro names.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/1664368073-13659-6-git-send-email-quic_srivasam@quicinc.com
drivers/remoteproc/qcom_q6v5_adsp.c

index b8cbbf7..14c94af 100644 (file)
@@ -54,6 +54,9 @@
 
 #define QCOM_Q6V5_RPROC_PROXY_PD_MAX   3
 
+#define LPASS_BOOT_CORE_START  BIT(0)
+#define LPASS_BOOT_CMD_START   BIT(0)
+
 struct adsp_pil_data {
        int crash_reason_smem;
        const char *firmware_name;
@@ -365,10 +368,10 @@ static int adsp_start(struct rproc *rproc)
        writel(adsp->mem_phys >> 4, adsp->qdsp6ss_base + RST_EVB_REG);
 
        /* De-assert QDSP6 stop core. QDSP6 will execute after out of reset */
-       writel(0x1, adsp->qdsp6ss_base + CORE_START_REG);
+       writel(LPASS_BOOT_CORE_START, adsp->qdsp6ss_base + CORE_START_REG);
 
        /* Trigger boot FSM to start QDSP6 */
-       writel(0x1, adsp->qdsp6ss_base + BOOT_CMD_REG);
+       writel(LPASS_BOOT_CMD_START, adsp->qdsp6ss_base + BOOT_CMD_REG);
 
        /* Wait for core to come out of reset */
        ret = readl_poll_timeout(adsp->qdsp6ss_base + BOOT_STATUS_REG,