cifs: Skip any trailing backslashes from UNC
authorPaulo Alcantara <palcantara@suse.de>
Wed, 14 Nov 2018 16:03:40 +0000 (14:03 -0200)
committerSteve French <stfrench@microsoft.com>
Mon, 24 Dec 2018 05:05:05 +0000 (23:05 -0600)
When extracting hostname from UNC, check for leading backslashes
before trying to remove them.

Signed-off-by: Paulo Alcantara <palcantara@suse.de>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/connect.c

index 944188d..bab4422 100644 (file)
@@ -1044,7 +1044,12 @@ extract_hostname(const char *unc)
 
        /* skip double chars at beginning of string */
        /* BB: check validity of these bytes? */
-       src = unc + 2;
+       if (strlen(unc) < 3)
+               return ERR_PTR(-EINVAL);
+       for (src = unc; *src && *src == '\\'; src++)
+               ;
+       if (!*src)
+               return ERR_PTR(-EINVAL);
 
        /* delimiter between hostname and sharename is always '\\' now */
        delim = strchr(src, '\\');