libebl: Don't update w, t and len unnecessarily in ebl_object_note_type_name.

Harmless, but useless.

Signed-off-by: Mark Wielaard <mark@klomp.org>

diff --git a/libebl/ChangeLog b/libebl/ChangeLog
index 79a2ff4..a2f8956 100644 (file)
--- a/libebl/ChangeLog
+++ b/libebl/ChangeLog
@@ -1,3 +1,8 @@
+2018-11-15  Mark Wielaard  <mark@klomp.org>
+
+       * eblobjnotetypename.c (ebl_object_note_type_name): Don't update
+       w, t and len unnecessarily.
+
 2018-11-12  Mark Wielaard  <mark@klomp.org>
 
        * libebl.h (ebl_object_note): Add new argument namesz.

diff --git a/libebl/eblobjnotetypename.c b/libebl/eblobjnotetypename.c
index 29a5391..6b803ce 100644 (file)
--- a/libebl/eblobjnotetypename.c
+++ b/libebl/eblobjnotetypename.c
@@ -91,13 +91,11 @@ ebl_object_note_type_name (Ebl *ebl, const char *name, uint32_t type,
          t += w;
          len -= w;
          if (type == NT_GNU_BUILD_ATTRIBUTE_OPEN)
-           w = snprintf (t, len, "OPEN");
+           snprintf (t, len, "OPEN");
          else if (type == NT_GNU_BUILD_ATTRIBUTE_FUNC)
-           w = snprintf (t, len, "FUNC");
+           snprintf (t, len, "FUNC");
          else
-           w = snprintf (t, len, "%x", type);
-         t += w;
-         len -= w;
+           snprintf (t, len, "%x", type);
 
          return buf;
        }