usb: chipidea: imx: avoid unnecessary probe defer
authorThomas Ballasi <thomas.ballasi@savoirfairelinux.com>
Thu, 30 Mar 2023 22:16:37 +0000 (18:16 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Apr 2023 17:16:59 +0000 (19:16 +0200)
The changes brought by commit 73de93440186 have been inadvertidly
removed, causing ci_hdrc_imx's probe to be loaded before usbmisc_imx's,
despite ci_hdrc_imx needing usbmisc_imx.

This condition may cause unexpected behaviors, especially when the
ChipIdea node is being referred to under /sys/class/udc/:

$ ls -l /sys/class/udc/
$

when it should show as the following:

$ ls -l /sys/class/udc/
ci_hdrc.0 -> ../../devices/[...]/ci_hdrc.0/udc/ci_hdrc.0

Some userspace tools may depend on this feature[1].

[1]: https://github.com/nxp-imx/imx-uuc/blob/69029e71b0642ded83a6c9bfa03102bb310c88ed/linuxrc#L148

Fixes: 95caa2ae70fd ("usb: chipidea: allow disabling glue drivers if EMBEDDED")
Signed-off-by: Thomas Ballasi <thomas.ballasi@savoirfairelinux.com>
Link: https://lore.kernel.org/r/20230330221637.1605161-1-thomas.ballasi@savoirfairelinux.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/Makefile

index 6f4a3de..71afeab 100644 (file)
@@ -14,5 +14,5 @@ ci_hdrc-$(CONFIG_USB_OTG_FSM)         += otg_fsm.o
 obj-$(CONFIG_USB_CHIPIDEA_GENERIC)     += ci_hdrc_usb2.o
 obj-$(CONFIG_USB_CHIPIDEA_MSM)         += ci_hdrc_msm.o
 obj-$(CONFIG_USB_CHIPIDEA_PCI)         += ci_hdrc_pci.o
-obj-$(CONFIG_USB_CHIPIDEA_IMX)         += ci_hdrc_imx.o usbmisc_imx.o
+obj-$(CONFIG_USB_CHIPIDEA_IMX)         += usbmisc_imx.o ci_hdrc_imx.o
 obj-$(CONFIG_USB_CHIPIDEA_TEGRA)       += ci_hdrc_tegra.o