staging: wfx: remove false positive warning

When a station is removed, the driver check that all the Tx frames were
correctly sent. However, the station can be removed before all the Tx
frames were acknowledged and a false positive warning can be emitted.

The previous commit has added a trace when driver received an
acknowledge for a non-existent station. It appear that these events
are perfectly correlated and there is no leak.

Now, the subject is perfectly understood. Remove the warning. Just keep
a debug trace in case we have any doubt in the future.

In the past, the subject has already been discussed here:
   https://lore.kernel.org/driverdev-devel/6287924.ghGFUMk3OD@pc-42/

Fixes: 4bbc6a3e7ad0 ("staging: wfx: make warning about pending frame less scary")
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200515083325.378539-20-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index f448957..6015cd2 100644 (file)
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -441,8 +441,10 @@ int wfx_sta_remove(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 
        for (i = 0; i < ARRAY_SIZE(sta_priv->buffered); i++)
                if (sta_priv->buffered[i])
-                       dev_warn(wvif->wdev->dev, "release station while %d pending frame on queue %d",
-                                sta_priv->buffered[i], i);
+                       // Not an error if paired with trace in
+                       // wfx_tx_update_sta()
+                       dev_dbg(wvif->wdev->dev, "release station while %d pending frame on queue %d",
+                               sta_priv->buffered[i], i);
        // See note in wfx_sta_add()
        if (!sta_priv->link_id)
                return 0;