clock: Return FALSE in all paths that don't set out parameters in gst_clock_add_obser...

It returned TRUE when regression failed, while not setting any of the out
parameters. This caused uninitialized data from the stack to be used for
setting the clock calibration.

diff --git a/gst/gstclock.c b/gst/gstclock.c
index 7e9be2f..3f6d891 100644 (file)
--- a/gst/gstclock.c
+++ b/gst/gstclock.c
@@ -1474,7 +1474,7 @@ invalid:
   {
     /* no valid regression has been done, ignore the result then */
     GST_CLOCK_SLAVE_UNLOCK (clock);
-    return TRUE;
+    return FALSE;
   }
 }