svcrdma: fix bounce buffers for unaligned offsets and multiple pages
authorDan Aloni <dan@kernelim.com>
Fri, 2 Oct 2020 19:33:43 +0000 (22:33 +0300)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 16 Oct 2020 19:15:04 +0000 (15:15 -0400)
This was discovered using O_DIRECT at the client side, with small
unaligned file offsets or IOs that span multiple file pages.

Fixes: e248aa7be86 ("svcrdma: Remove max_sge check at connect time")
Signed-off-by: Dan Aloni <dan@kernelim.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/xprtrdma/svc_rdma_sendto.c

index 7b94d97..c3d588b 100644 (file)
@@ -638,10 +638,11 @@ static int svc_rdma_pull_up_reply_msg(struct svcxprt_rdma *rdma,
                while (remaining) {
                        len = min_t(u32, PAGE_SIZE - pageoff, remaining);
 
-                       memcpy(dst, page_address(*ppages), len);
+                       memcpy(dst, page_address(*ppages) + pageoff, len);
                        remaining -= len;
                        dst += len;
                        pageoff = 0;
+                       ppages++;
                }
        }