SHM: Don't flush damage when there is none
authorDaniel Stone <daniel@fooishbar.org>
Wed, 7 Nov 2012 06:51:42 +0000 (17:51 +1100)
committerKristian Høgsberg <krh@bitplanet.net>
Thu, 8 Nov 2012 16:31:37 +0000 (11:31 -0500)
Every single frame, we were calling the flush_damage handler in the
renderer.  For GLES2 with subimage, this wasn't too bad as we'd never
call glTexSubImage2D, but without it, we'd upload the entire frame
through glTexImage2D every time.

Signed-off-by: Daniel Stone <daniel@fooishbar.org>
src/compositor.c

index 2d5b263..6b0c004 100644 (file)
@@ -905,7 +905,8 @@ static void
 surface_accumulate_damage(struct weston_surface *surface,
                          pixman_region32_t *opaque)
 {
-       if (surface->buffer && wl_buffer_is_shm(surface->buffer))
+       if (pixman_region32_not_empty(&surface->damage) &&
+           surface->buffer && wl_buffer_is_shm(surface->buffer))
                surface->compositor->renderer->flush_damage(surface);
 
        if (surface->transform.enabled) {