wifi: mt76: mt7915: drop always true condition of __mt7915_reg_addr()
authorRyder Lee <ryder.lee@mediatek.com>
Sun, 4 Dec 2022 07:18:14 +0000 (15:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:32:47 +0000 (09:32 +0100)
[ Upstream commit b0f7b9563358493dfe70d3e4c3ebeffc92d4b494 ]

smatch warnings:
addr <= MT_CBTOP2_PHY_END(0xffffffff) is always true (<= u32max),
so drop it.

Fixes: cd4c314a65d3 ("mt76: mt7915: refine register definition")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
drivers/net/wireless/mediatek/mt76/mt7915/regs.h

index 7bd5f67..bc68ede 100644 (file)
@@ -436,7 +436,7 @@ static u32 __mt7915_reg_addr(struct mt7915_dev *dev, u32 addr)
 
        if (dev_is_pci(dev->mt76.dev) &&
            ((addr >= MT_CBTOP1_PHY_START && addr <= MT_CBTOP1_PHY_END) ||
-            (addr >= MT_CBTOP2_PHY_START && addr <= MT_CBTOP2_PHY_END)))
+           addr >= MT_CBTOP2_PHY_START))
                return mt7915_reg_map_l1(dev, addr);
 
        /* CONN_INFRA: covert to phyiscal addr and use layer 1 remap */
index 5920e70..bf569aa 100644 (file)
@@ -740,7 +740,6 @@ enum offs_rev {
 #define MT_CBTOP1_PHY_START            0x70000000
 #define MT_CBTOP1_PHY_END              __REG(CBTOP1_PHY_END)
 #define MT_CBTOP2_PHY_START            0xf0000000
-#define MT_CBTOP2_PHY_END              0xffffffff
 #define MT_INFRA_MCU_START             0x7c000000
 #define MT_INFRA_MCU_END               __REG(INFRA_MCU_ADDR_END)
 #define MT_CONN_INFRA_OFFSET(p)                ((p) - MT_INFRA_BASE)