projects
/
kernel
/
kernel-generic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4b95320
)
[AGPGART] Prevent (unlikely) memory leak in amd_create_gatt_pages()
author
Dave Jones
<davej@redhat.com>
Sun, 28 Jan 2007 22:39:19 +0000
(17:39 -0500)
committer
Dave Jones
<davej@redhat.com>
Sun, 28 Jan 2007 22:39:19 +0000
(17:39 -0500)
If we fail an alloc, unwind the previous allocs that succeeded.
Spotted-by: Alan Grimes <agrimes@speakeasy.net>
Signed-off-by: Dave Jones <davej@redhat.com>
drivers/char/agp/amd-k7-agp.c
patch
|
blob
|
history
diff --git
a/drivers/char/agp/amd-k7-agp.c
b/drivers/char/agp/amd-k7-agp.c
index
51d0d56
..
c85c8ca
100644
(file)
--- a/
drivers/char/agp/amd-k7-agp.c
+++ b/
drivers/char/agp/amd-k7-agp.c
@@
-101,6
+101,11
@@
static int amd_create_gatt_pages(int nr_tables)
for (i = 0; i < nr_tables; i++) {
entry = kzalloc(sizeof(struct amd_page_map), GFP_KERNEL);
if (entry == NULL) {
+ while (i > 0) {
+ kfree(tables[i-1]);
+ i--;
+ }
+ kfree(tables);
retval = -ENOMEM;
break;
}