pstore: Rename "pstore_lock" to "psinfo_lock"
authorKees Cook <keescook@chromium.org>
Wed, 6 May 2020 06:29:10 +0000 (23:29 -0700)
committerKees Cook <keescook@chromium.org>
Tue, 12 May 2020 16:13:29 +0000 (09:13 -0700)
The name "pstore_lock" sounds very global, but it is only supposed to be
used for managing changes to "psinfo", so rename it accordingly.

Link: https://lore.kernel.org/lkml/20200506152114.50375-3-keescook@chromium.org/
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/pstore/platform.c

index 44f8b97..347b6c0 100644 (file)
@@ -69,10 +69,10 @@ static void pstore_dowork(struct work_struct *);
 static DECLARE_WORK(pstore_work, pstore_dowork);
 
 /*
- * pstore_lock just protects "psinfo" during
+ * psinfo_lock just protects "psinfo" during
  * calls to pstore_register()
  */
-static DEFINE_SPINLOCK(pstore_lock);
+static DEFINE_SPINLOCK(psinfo_lock);
 struct pstore_info *psinfo;
 
 static char *backend;
@@ -574,11 +574,11 @@ int pstore_register(struct pstore_info *psi)
                return -EINVAL;
        }
 
-       spin_lock(&pstore_lock);
+       spin_lock(&psinfo_lock);
        if (psinfo) {
                pr_warn("backend '%s' already loaded: ignoring '%s'\n",
                        psinfo->name, psi->name);
-               spin_unlock(&pstore_lock);
+               spin_unlock(&psinfo_lock);
                return -EBUSY;
        }
 
@@ -587,7 +587,7 @@ int pstore_register(struct pstore_info *psi)
        psinfo = psi;
        mutex_init(&psinfo->read_mutex);
        sema_init(&psinfo->buf_lock, 1);
-       spin_unlock(&pstore_lock);
+       spin_unlock(&psinfo_lock);
 
 
        if (psi->flags & PSTORE_FLAGS_DMESG)