Add new DCM_ERROR_MSG_FORMAT error enum

In case of wrong message format we should return DCM_ERROR_MSG_FORMAT
instead of DCM_ERROR_NOT_SUPPORTED, which is designed for not supported features.

Change-Id: I794ff7a7bd41932b8099d17eaf47a23b0749c7dc

diff --git a/src/include/device_certificate_manager.h b/src/include/device_certificate_manager.h
index 698ca5e..a85c8d1 100644 (file)
--- a/src/include/device_certificate_manager.h
+++ b/src/include/device_certificate_manager.h
@@ -46,6 +46,7 @@ typedef enum {
     DCM_ERROR_UNKNOWN = TIZEN_ERROR_UNKNOWN, /**< Unknown error */
 
     DCM_ERROR_SOCKET = TIZEN_ERROR_DEVICE_CERTIFICATE_MANAGER | 0x01, /**< Socket error between client and server */
+    DCM_ERROR_MSG_FORMAT = TIZEN_ERROR_DEVICE_CERTIFICATE_MANAGER | 0x02, /**< Message is not in Tizen platform format (Since 6.5) */
 } dcm_error_e;
 
 
@@ -249,9 +250,9 @@ typedef struct dcm_e2ee_bundle_s* dcm_e2ee_bundle_h;
  * @return #DCM_ERROR_NONE on success, otherwise a negative error value
  *
  * @retval #DCM_ERROR_NONE Successful
- * @retval #DCM_ERROR_NOT_SUPPORTED The message is not in Tizen platform format.
  * @retval #DCM_ERROR_INVALID_PARAMETER Input parameter is invalid (message = NULL or bundle = NULL)
  *                                      or the message format is invalid.
+ * @retval #DCM_ERROR_MSG_FORMAT The message is not in Tizen platform format.
  *
  * @see dcm_e2ee_free_bundle()
  * @see #dcm_e2ee_bundle_h

diff --git a/src/shared/bundle.cpp b/src/shared/bundle.cpp
index 7120aea..1df225c 100644 (file)
--- a/src/shared/bundle.cpp
+++ b/src/shared/bundle.cpp
@@ -63,7 +63,7 @@ int decompose_e2ee_message(
                return DCM_ERROR_INVALID_PARAMETER; // wrong format
 
        if (strcmp(message_str, PLATFORM) != 0)
-               return DCM_ERROR_NOT_SUPPORTED; // not a Tizen bundle
+               return DCM_ERROR_MSG_FORMAT; // not a Tizen bundle
 
        pkg_id_offset++; // skip \0
        message_str += pkg_id_offset;

diff --git a/tests/api_test.cpp b/tests/api_test.cpp
index 3650a7f..f888c24 100644 (file)
--- a/tests/api_test.cpp
+++ b/tests/api_test.cpp
@@ -516,7 +516,7 @@ NEGATIVE_TEST_CASE(test21_dcm_e2ee_bundle_api) {
     assert_invalid_param(dcm_e2ee_create_bundle, payload,  sizeof(payload),  &bundle);
     assert_invalid_param(dcm_e2ee_create_bundle, payload2, sizeof(payload2), &bundle);
 
-    BOOST_REQUIRE_EQUAL(dcm_e2ee_create_bundle(msg2, size2, &bundle), DCM_ERROR_NOT_SUPPORTED);
+    BOOST_REQUIRE_EQUAL(dcm_e2ee_create_bundle(msg2, size2, &bundle), DCM_ERROR_MSG_FORMAT);
 
     assert_positive(dcm_e2ee_create_bundle, msg, size, &bundle);
     msgPtr.release();