iavf: Refactor string format to avoid static analysis warnings
authorKaren Sornek <karen.sornek@intel.com>
Tue, 31 Aug 2021 11:39:01 +0000 (13:39 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 30 Nov 2021 16:56:07 +0000 (08:56 -0800)
Change format to match variable type that is used in string.

Use %u format for unsigned variable and %d format for signed variable
to remove static analysis warnings.

Signed-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com>
Signed-off-by: Karen Sornek <karen.sornek@intel.com>
Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/iavf/iavf_main.c
drivers/net/ethernet/intel/iavf/iavf_virtchnl.c

index a6f10d9..285c0e2 100644 (file)
@@ -463,14 +463,14 @@ iavf_request_traffic_irqs(struct iavf_adapter *adapter, char *basename)
 
                if (q_vector->tx.ring && q_vector->rx.ring) {
                        snprintf(q_vector->name, sizeof(q_vector->name),
-                                "iavf-%s-TxRx-%d", basename, rx_int_idx++);
+                                "iavf-%s-TxRx-%u", basename, rx_int_idx++);
                        tx_int_idx++;
                } else if (q_vector->rx.ring) {
                        snprintf(q_vector->name, sizeof(q_vector->name),
-                                "iavf-%s-rx-%d", basename, rx_int_idx++);
+                                "iavf-%s-rx-%u", basename, rx_int_idx++);
                } else if (q_vector->tx.ring) {
                        snprintf(q_vector->name, sizeof(q_vector->name),
-                                "iavf-%s-tx-%d", basename, tx_int_idx++);
+                                "iavf-%s-tx-%u", basename, tx_int_idx++);
                } else {
                        /* skip this unused q_vector */
                        continue;
index b902650..cfa1f0e 100644 (file)
@@ -1025,7 +1025,7 @@ print_link_msg:
        } else if (link_speed_mbps == SPEED_UNKNOWN) {
                snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%s", "Unknown Mbps");
        } else {
-               snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%u %s",
+               snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
                         link_speed_mbps, "Mbps");
        }