qtdemux: Avoid crash on reconfiguring.
authorJan Schmidt <jan@centricular.com>
Fri, 12 Aug 2022 10:20:43 +0000 (20:20 +1000)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Tue, 16 Aug 2022 19:01:28 +0000 (19:01 +0000)
When reconfiguring a stream that never created
an output pad, don't access a NULL GstPad pointer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2869>

subprojects/gst-plugins-good/gst/isomp4/qtdemux.c

index d9f118c..7ce652a 100644 (file)
@@ -13596,7 +13596,8 @@ qtdemux_reuse_and_configure_stream (GstQTDemux * qtdemux,
 
   /* unset new_stream to prevent stream-start event, unless we are EOS in which
    * case we need to force one through */
-  newstream->new_stream = GST_PAD_IS_EOS (newstream->pad);
+  newstream->new_stream = newstream->pad != NULL
+      && GST_PAD_IS_EOS (newstream->pad);
 
   return gst_qtdemux_configure_stream (qtdemux, newstream);
 }