Fix gdb.threads/dlopen-libpthread.exp crash

Following, commit

  6e774b13c3b81ac2599812adf058796948ce7e95 Make ftrace tests work with remote targets

the test gdb.threads/dlopen-libpthread.exp started to fail with:

  ERROR: error copying "/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.threads/dlopen-libpthread.so": no such file or directory

This is because the library path is not computed using
standard_output_file, so we try to gdb_load_shlibs an unexisting file.

gdb/testsuite/ChangeLog:

	* gdb.threads/dlopen-libpthread.exp: Set binfile_lib using
	standard_output_file.  Remove unused binfile variable.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 27806a0..df16023 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-04-06  Simon Marchi  <simon.marchi@ericsson.com>
+
+       * gdb.threads/dlopen-libpthread.exp: Set binfile_lib using
+       standard_output_file.  Remove unused binfile variable.
+
 2016-04-05  Catalin Udma  <catalin.udma@freescale.com>
 
        * gdb.python/py-mi-objfile-gdb.py: Use "list main" command.

diff --git a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp
index 33789cc..206b16a 100644 (file)
--- a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp
+++ b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp
@@ -23,8 +23,7 @@ set testfile "dlopen-libpthread"
 set srcmainfile ${testfile}.c
 set srclibfile ${testfile}-lib.c
 set executable ${testfile}
-set binfile_lib ${objdir}/${subdir}/${executable}.so
-set binfile ${objdir}/${subdir}/${executable}
+set binfile_lib [standard_output_file ${executable}.so]
 set lib_dlopen [shlib_target_file ${executable}.so]
 
 # Use build_executable_own_libs as prelinked libpthread.so can produce false