ARM: dts: qcom: Correct USB3503 GPIOs polarity
authorMarek Szyprowski <m.szyprowski@samsung.com>
Wed, 11 Dec 2019 14:52:08 +0000 (15:52 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Dec 2019 19:40:19 +0000 (20:40 +0100)
Current USB3503 driver ignores GPIO polarity and always operates as if the
GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing
USB3503 chip applications to match the chip specification and common
convention for naming the pins. The only pin, which has to be ACTIVE_LOW
is the reset pin. The remaining are ACTIVE_HIGH. This change allows later
to fix the USB3503 driver to properly use generic GPIO bindings and read
polarity from DT.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20191211145208.24976-1-m.szyprowski@samsung.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts

index 26160c3..942e3a2 100644 (file)
                                compatible = "smsc,usb3503a";
                                reg = <0x8>;
                                connect-gpios = <&gpioext2 1 GPIO_ACTIVE_HIGH>;
-                               intn-gpios = <&gpioext2 0 GPIO_ACTIVE_LOW>;
+                               intn-gpios = <&gpioext2 0 GPIO_ACTIVE_HIGH>;
                                initial-mode = <1>;
                        };
                };