ALSA: gus: Fix erroneous memory allocation
authorTakashi Iwai <tiwai@suse.de>
Mon, 13 Dec 2021 13:24:43 +0000 (14:24 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 13 Dec 2021 14:07:14 +0000 (15:07 +0100)
snd_gf1_mem_xalloc() returns NULL incorrectly when the memory chunk is
allocated in the middle of the chain.  This patch corrects the return
value to treat it properly.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Link: https://lore.kernel.org/r/20211213132444.22385-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/gus/gus_mem.c

index 4c691db..5e3ff31 100644 (file)
@@ -44,7 +44,7 @@ static struct snd_gf1_mem_block *snd_gf1_mem_xalloc(struct snd_gf1_mem * alloc,
                        else
                                nblock->prev->next = nblock;
                        mutex_unlock(&alloc->memory_mutex);
-                       return NULL;
+                       return nblock;
                }
                pblock = pblock->next;
        }