[debugger] Remove assert when the DebuggerTypeProxy cannot be instantiated (#34966)

Remove the assert because we don't need to stop the debug if we cannot create the object when calling the constructor using invoke_method, if it's a DebuggerTypeProxy, we are not able to show the value of the DebuggerTypeProxy, but we still can show the Raw View, if it's not the case of DebuggerTypeProxy, we just cannot evaluate this expression, but we can continue the debug session.

Fix mono/mono#19492

Co-authored-by: thaystg <thaystg@users.noreply.github.com>

diff --git a/src/mono/mono/mini/debugger-agent.c b/src/mono/mono/mini/debugger-agent.c
index 7dbbe74..3742cc0 100644 (file)
--- a/src/mono/mono/mini/debugger-agent.c
+++ b/src/mono/mono/mini/debugger-agent.c
@@ -6549,7 +6549,8 @@ do_invoke_method (DebuggerTlsData *tls, Buffer *buf, InvokeData *invoke, guint8
                        else {
                                ERROR_DECL (error);
                                this_arg = mono_object_new_checked (domain, m->klass, error);
-                               mono_error_assert_ok (error);
+                               if (!is_ok (error))
+                                       return ERR_INVALID_ARGUMENT;
                        }
                } else {
                        return ERR_INVALID_ARGUMENT;