clk: sprd: return correct type of value for _sprd_pll_recalc_rate
authorChunyan Zhang <chunyan.zhang@unisoc.com>
Tue, 19 May 2020 03:00:36 +0000 (11:00 +0800)
committerStephen Boyd <sboyd@kernel.org>
Wed, 27 May 2020 03:14:56 +0000 (20:14 -0700)
The function _sprd_pll_recalc_rate() defines return value to unsigned
long, but it would return a negative value when malloc fail, changing
to return its parent_rate makes more sense, since if the callback
.recalc_rate() is not set, the framework returns the parent_rate as
well.

Fixes: 3e37b005580b ("clk: sprd: add adjustable pll support")
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Link: https://lkml.kernel.org/r/20200519030036.1785-2-zhang.lyra@gmail.com
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/sprd/pll.c

index 1579148..13a322b 100644 (file)
@@ -106,7 +106,7 @@ static unsigned long _sprd_pll_recalc_rate(const struct sprd_pll *pll,
 
        cfg = kcalloc(regs_num, sizeof(*cfg), GFP_KERNEL);
        if (!cfg)
-               return -ENOMEM;
+               return parent_rate;
 
        for (i = 0; i < regs_num; i++)
                cfg[i] = sprd_pll_read(pll, i);