RDMA/rxe: Replace __rxe_do_task by rxe_run_task
authorBob Pearson <rpearsonhpe@gmail.com>
Thu, 30 Jun 2022 19:04:26 +0000 (14:04 -0500)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 22 Jul 2022 20:43:00 +0000 (17:43 -0300)
In rxe_req.c replace calls to __rxe_do_task() by calls to rxe_run_task(..,
0). Using __rxe_do_task is an error because the completer tasklet is not
designed to be re-entrant and __rxe_do_task() should only be called when
it is clear that no one else could be calling the completer tasklet as is
the case in rxe_qp.c where this call is used in safe environments.

Link: https://lore.kernel.org/r/20220630190425.2251-10-rpearsonhpe@gmail.com
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/sw/rxe/rxe_req.c

index f97e8c1..49e8f54 100644 (file)
@@ -722,7 +722,7 @@ int rxe_requester(void *arg)
                                                       qp->req.wqe_index);
                        wqe->state = wqe_state_done;
                        wqe->status = IB_WC_SUCCESS;
-                       __rxe_do_task(&qp->comp.task);
+                       rxe_run_task(&qp->comp.task, 0);
                        goto done;
                }
                payload = mtu;
@@ -803,7 +803,7 @@ done:
        goto out;
 err:
        wqe->state = wqe_state_error;
-       __rxe_do_task(&qp->comp.task);
+       rxe_run_task(&qp->comp.task, 0);
 exit:
        ret = -EAGAIN;
 out: