f2fs: remove unnecessary f2fs_lock_op in f2fs_new_inode
authorJaegeuk Kim <jaegeuk@kernel.org>
Wed, 23 Mar 2022 20:30:04 +0000 (13:30 -0700)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 25 Apr 2022 22:13:02 +0000 (15:13 -0700)
This can be removed, since f2fs_alloc_nid() actually doesn't require to block
checkpoint and __f2fs_build_free_nids() is covered by nm_i->nat_tree_lock.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/namei.c

index 5ed79b2..8162854 100644 (file)
@@ -37,13 +37,10 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns,
        if (!inode)
                return ERR_PTR(-ENOMEM);
 
-       f2fs_lock_op(sbi);
        if (!f2fs_alloc_nid(sbi, &ino)) {
-               f2fs_unlock_op(sbi);
                err = -ENOSPC;
                goto fail;
        }
-       f2fs_unlock_op(sbi);
 
        nid_free = true;