virtio-mmio: Use PTR_ERR_OR_ZERO()
authorVasyl Gomonovych <gomonovych@gmail.com>
Tue, 28 Nov 2017 15:15:47 +0000 (16:15 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 30 Jan 2018 23:47:34 +0000 (01:47 +0200)
Fix ptr_ret.cocci warnings:
drivers/virtio/virtio_mmio.c:653:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/virtio/virtio_mmio.c

index c92131e..b43ac9b 100644 (file)
@@ -662,10 +662,8 @@ static int vm_cmdline_set(const char *device,
        pdev = platform_device_register_resndata(&vm_cmdline_parent,
                        "virtio-mmio", vm_cmdline_id++,
                        resources, ARRAY_SIZE(resources), NULL, 0);
-       if (IS_ERR(pdev))
-               return PTR_ERR(pdev);
 
-       return 0;
+       return PTR_ERR_OR_ZERO(pdev);
 }
 
 static int vm_cmdline_get_device(struct device *dev, void *data)