mmc: tmio: remove workaround for NON_REMOVABLE
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 18 Feb 2021 11:02:24 +0000 (12:02 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 30 Mar 2021 09:41:58 +0000 (11:41 +0200)
RPM handling has been improved twice since this comment, and also SCC
handling has been improved a lot. All the testing we did (Geert's and
Niklas' and Wolfram's board farms) with the workaround removed did not
lead to problems, so it is time to get rid of it to the best of our
knowledge.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20210218110224.6910-1-wsa+renesas@sang-engineering.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc_core.c

index 49c2d40..2478a91 100644 (file)
@@ -1161,15 +1161,6 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host)
                                  !mmc_card_is_removable(mmc));
 
        /*
-        * On Gen2+, eMMC with NONREMOVABLE currently fails because native
-        * hotplug gets disabled. It seems RuntimePM related yet we need further
-        * research. Since we are planning a PM overhaul anyway, let's enforce
-        * for now the device being active by enabling native hotplug always.
-        */
-       if (pdata->flags & TMIO_MMC_MIN_RCAR2)
-               _host->native_hotplug = true;
-
-       /*
         * While using internal tmio hardware logic for card detection, we need
         * to ensure it stays powered for it to work.
         */