scsi: mptfusion: Remove redundant variable r
authorColin Ian King <colin.i.king@gmail.com>
Sun, 5 Dec 2021 22:59:01 +0000 (22:59 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 7 Dec 2021 03:22:18 +0000 (22:22 -0500)
Variable r is being assigned a value that is never read. The assignment is
redundant and so is the variable, so remove these. Remove unnecessary the
{} braces in the if statement too.

Link: https://lore.kernel.org/r/20211205225901.54362-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/mptbase.c

index b94d5e4..24a4532 100644 (file)
@@ -1274,8 +1274,6 @@ mpt_send_handshake_request(u8 cb_idx, MPT_ADAPTER *ioc, int reqBytes, u32 *req,
 static int
 mpt_host_page_access_control(MPT_ADAPTER *ioc, u8 access_control_value, int sleepFlag)
 {
-       int      r = 0;
-
        /* return if in use */
        if (CHIPREG_READ32(&ioc->chip->Doorbell)
            & MPI_DOORBELL_ACTIVE)
@@ -1289,9 +1287,9 @@ mpt_host_page_access_control(MPT_ADAPTER *ioc, u8 access_control_value, int slee
                 (access_control_value<<12)));
 
        /* Wait for IOC to clear Doorbell Status bit */
-       if ((r = WaitForDoorbellAck(ioc, 5, sleepFlag)) < 0) {
+       if (WaitForDoorbellAck(ioc, 5, sleepFlag) < 0)
                return -2;
-       }else
+       else
                return 0;
 }