PCI: cadence: Remove pci_epf_linkup() from Cadence EP driver
authorKishon Vijay Abraham I <kishon@ti.com>
Mon, 14 Jan 2019 11:15:10 +0000 (16:45 +0530)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 15 Feb 2019 10:02:38 +0000 (10:02 +0000)
pci_epf_linkup() is intended to be invoked if the EPC supports linkup
notification. Now that pci-epf-test uses the get_features() callback,
which indicates Cadence EP driver doesn't support the linkup notification,
remove pci_epf_linkup() from Cadence EP driver.

Tested-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/controller/pcie-cadence-ep.c

index 14c2545..def7820 100644 (file)
@@ -396,18 +396,6 @@ static int cdns_pcie_ep_start(struct pci_epc *epc)
                cfg |= BIT(epf->func_no);
        cdns_pcie_writel(pcie, CDNS_PCIE_LM_EP_FUNC_CFG, cfg);
 
-       /*
-        * The PCIe links are automatically established by the controller
-        * once for all at powerup: the software can neither start nor stop
-        * those links later at runtime.
-        *
-        * Then we only have to notify the EP core that our links are already
-        * established. However we don't call directly pci_epc_linkup() because
-        * we've already locked the epc->lock.
-        */
-       list_for_each_entry(epf, &epc->pci_epf, list)
-               pci_epf_linkup(epf);
-
        return 0;
 }