INTERNAL: remove potential bugs

add null check, synchronization check

Change-Id: I6543b822bbe4e17c10cd8e65605df00f738aae24
Signed-off-by: woojin <woojin2.jung@samsung.com>

diff --git a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/callstack/BaseCallstackManager.java b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/callstack/BaseCallstackManager.java
index 776d602..8509e6e 100644 (file)
--- a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/callstack/BaseCallstackManager.java
+++ b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/callstack/BaseCallstackManager.java
@@ -57,7 +57,7 @@ import org.tizen.dynamicanalyzer.util.Logger;
 import org.tizen.dynamicanalyzer.utils.AnalyzerUtil;
 
 public abstract class BaseCallstackManager {
-       protected class DuplicateUserCall {
+       protected static class DuplicateUserCall {
                private CallStackUnit dupCallstackUnit = null;
                private int dupCallcount = 0;
 

diff --git a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/summary/profiling/ProfileDataMaker.java b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/summary/profiling/ProfileDataMaker.java
index a0bd724..b4b0e5d 100644 (file)
--- a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/summary/profiling/ProfileDataMaker.java
+++ b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/summary/profiling/ProfileDataMaker.java
@@ -51,7 +51,7 @@ import org.tizen.dynamicanalyzer.util.Logger;
 import org.tizen.dynamicanalyzer.utils.Formatter;
 
 public class ProfileDataMaker {
-       class CallstackTree {
+       static class CallstackTree {
                ProfilingData me;
                CallstackTree parent;
                List<CallstackTree> children = null;
@@ -417,6 +417,10 @@ public class ProfileDataMaker {
                                } else {
                                        String pName = fupData.getParent();
                                        ProfilingData inParent = getProfilingDataByKey(pName);
+                                       if (inParent == null) {
+                                               Logger.error("ProfilingData: function item without library item");
+                                               continue;
+                                       }
                                        inParent.addInCount(totalSampleCount);
 
                                        if (null != inParent.getParent()) {