nfc: virtual_ncidev: change default device permissions
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 25 Nov 2021 14:14:57 +0000 (11:14 -0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 26 Nov 2021 19:14:31 +0000 (11:14 -0800)
Device permissions is S_IALLUGO, with many unnecessary bits. Remove them
and also remove read and write permissions from group and others.

Before the change:
crwsrwsrwt    1 0        0          10, 125 Nov 25 13:59 /dev/virtual_nci

After the change:
crw-------    1 0        0          10, 125 Nov 25 14:05 /dev/virtual_nci

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Bongsu Jeon <bongsu.jeon@samsung.com>
Link: https://lore.kernel.org/r/20211125141457.716921-1-cascardo@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/virtual_ncidev.c

index 221fa3b..f577449 100644 (file)
@@ -202,7 +202,7 @@ static int __init virtual_ncidev_init(void)
        miscdev.minor = MISC_DYNAMIC_MINOR;
        miscdev.name = "virtual_nci";
        miscdev.fops = &virtual_ncidev_fops;
-       miscdev.mode = S_IALLUGO;
+       miscdev.mode = 0600;
 
        return misc_register(&miscdev);
 }