nvme-pci: remove redundant segment validation
authorBaolin Wang <baolin.wang@linux.alibaba.com>
Fri, 3 Jul 2020 02:49:22 +0000 (10:49 +0800)
committerChristoph Hellwig <hch@lst.de>
Wed, 8 Jul 2020 14:16:21 +0000 (16:16 +0200)
We've validated the segment counts before calling nvme_map_data(),
so there is no need to validate again in nvme_pci_use_sgls(, which is
only called from nvme_map_data().

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c

index 83585ed..9216cbd 100644 (file)
@@ -501,9 +501,6 @@ static inline bool nvme_pci_use_sgls(struct nvme_dev *dev, struct request *req)
        int nseg = blk_rq_nr_phys_segments(req);
        unsigned int avg_seg_size;
 
-       if (nseg == 0)
-               return false;
-
        avg_seg_size = DIV_ROUND_UP(blk_rq_payload_bytes(req), nseg);
 
        if (!(dev->ctrl.sgls & ((1 << 0) | (1 << 1))))