spi: slave: Fix missing break in switch
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 3 Oct 2018 12:33:28 +0000 (14:33 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 3 Oct 2018 15:23:10 +0000 (16:23 +0100)
Apparently, this code does not actually fall through to the next case
because the machine restarts before it has a chance. However, for the
sake of maintenance and readability, we better add the missing break
statement.

Addresses-Coverity-ID: 1437892 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-slave-system-control.c

index c0257e9..169f3d5 100644 (file)
@@ -60,6 +60,7 @@ static void spi_slave_system_control_complete(void *arg)
        case CMD_REBOOT:
                dev_info(&priv->spi->dev, "Rebooting system...\n");
                kernel_restart(NULL);
+               break;
 
        case CMD_POWEROFF:
                dev_info(&priv->spi->dev, "Powering off system...\n");