usb: core: Remove unnecessary memset()
authorSuwan Kim <suwan.kim027@gmail.com>
Tue, 4 Dec 2018 14:31:43 +0000 (23:31 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 12 Dec 2018 11:38:41 +0000 (12:38 +0100)
register_root_hub() calls memset() setting usb_dev->bus->devmap.
devicemap to 0 during hcd probe function (usb_hcd_pci_probe). But
in previous function which is also the procedure of usb_hcd_pci_probe(),
usb_bus_init() already initialized bus->devmap calling memset().
Furthermore, register_root_hub() is called only once in kernel.
So, calling memset() which resets usb_bus->devmap.devicemap in
register_root_hub() is redundant.

Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hcd.c

index 487025d..015b126 100644 (file)
@@ -1074,8 +1074,6 @@ static int register_root_hub(struct usb_hcd *hcd)
 
        usb_dev->devnum = devnum;
        usb_dev->bus->devnum_next = devnum + 1;
-       memset (&usb_dev->bus->devmap.devicemap, 0,
-                       sizeof usb_dev->bus->devmap.devicemap);
        set_bit (devnum, usb_dev->bus->devmap.devicemap);
        usb_set_device_state(usb_dev, USB_STATE_ADDRESS);