spi: Use device_find_any_child() instead of custom approach
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 10 Jun 2022 12:02:19 +0000 (15:02 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jun 2022 14:01:55 +0000 (16:01 +0200)
We have already a helper to get the first child device, use it and
drop custom approach.

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220610120219.18988-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/spi/spi.c

index ea09d1b..b04be04 100644 (file)
@@ -2613,11 +2613,6 @@ int spi_slave_abort(struct spi_device *spi)
 }
 EXPORT_SYMBOL_GPL(spi_slave_abort);
 
-static int match_true(struct device *dev, void *data)
-{
-       return 1;
-}
-
 static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
                          char *buf)
 {
@@ -2625,7 +2620,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
                                                   dev);
        struct device *child;
 
-       child = device_find_child(&ctlr->dev, NULL, match_true);
+       child = device_find_any_child(&ctlr->dev);
        return sprintf(buf, "%s\n",
                       child ? to_spi_device(child)->modalias : NULL);
 }
@@ -2644,7 +2639,7 @@ static ssize_t slave_store(struct device *dev, struct device_attribute *attr,
        if (rc != 1 || !name[0])
                return -EINVAL;
 
-       child = device_find_child(&ctlr->dev, NULL, match_true);
+       child = device_find_any_child(&ctlr->dev);
        if (child) {
                /* Remove registered slave */
                device_unregister(child);