Remove some dead code
authorJan Arve Saether <jan-arve.saether@digia.com>
Fri, 26 Oct 2012 09:01:47 +0000 (11:01 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Mon, 29 Oct 2012 19:27:37 +0000 (20:27 +0100)
This code became dead when the Symbian code was removed, and should
ideally have been removed at that point.

You can find the old code in 4.8 repo:
    bool showSystemDialogFullScreen = false;

    if (qobject_cast<QFileDialog *>(this) || qobject_cast<QFontDialog *>(this) ||
         qobject_cast<QWizard *>(this)) {
         showSystemDialogFullScreen = true;
    }

    if (showSystemDialogFullScreen) {
        setWindowFlags(windowFlags() | Qt::WindowSoftkeysVisibleHint);
        setWindowState(Qt::WindowFullScreen);
    }

So, obviously, stuff inside the #ifdef Q_OS_SYMBIAN was removed, but
the side-effect of that was not realized.....

Change-Id: I6b5d1066c97367c354af4da1ce6b9c60c8dc2120
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
src/widgets/dialogs/qdialog.cpp

index d2c3b2a..7b47f4e 100644 (file)
@@ -516,9 +516,6 @@ int QDialog::exec()
     setAttribute(Qt::WA_ShowModal, true);
     setResult(0);
 
-    bool showSystemDialogFullScreen = false;
-    if (showSystemDialogFullScreen)
-        setWindowState(Qt::WindowFullScreen);
     show();
 
     QPointer<QDialog> guard = this;