staging: ccree: remove extraneous spin_unlock_bh() in error handler
authorIan Chard <ian@chard.org>
Wed, 10 May 2017 09:20:59 +0000 (10:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 May 2017 09:48:44 +0000 (11:48 +0200)
An early error handler in send_request() tries to release a spinlock,
but the lock isn't acquired until the loop below it is entered.

Signed-off-by: Ian Chard <ian@chard.org>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_request_mgr.c

index 522bd62..8611adf 100644 (file)
@@ -376,7 +376,6 @@ int send_request(
        rc = ssi_power_mgr_runtime_get(&drvdata->plat_dev->dev);
        if (rc != 0) {
                SSI_LOG_ERR("ssi_power_mgr_runtime_get returned %x\n",rc);
-               spin_unlock_bh(&req_mgr_h->hw_lock);
                return rc;
        }
 #endif