file-helper: fix possible memleak

Assigning NULL to **str passed pointer on fgets() error
may result in being unable to free memory pointed by *str
(if it was previously allocated dynamically).

Change-Id: Ieda457c4d9da02dab277d476ed79537da41e744e
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>

diff --git a/src/common/file-helper.c b/src/common/file-helper.c
index e82a88b..c1737a4 100644 (file)
--- a/src/common/file-helper.c
+++ b/src/common/file-helper.c
@@ -93,15 +93,17 @@ int fwrite_ulong(const char *path, const unsigned long number)
 int fread_str(const char *path, char **str)
 {
        _cleanup_fclose_ FILE *f = NULL;
+       char *ret;
 
        f = fopen(path, "r");
        ret_value_errno_msg_if(!f, -errno,
                        "Fail to open %s file.", path);
 
-       *str = fgets(*str, LINE_MAX, f);
-       ret_value_errno_msg_if(!(*str), -ENODATA,
+       ret = fgets(*str, LINE_MAX, f);
+       ret_value_errno_msg_if(!ret, -ENODATA,
                        "Fail to read file\n");
 
+       *str = ret;
        return RESOURCED_ERROR_NONE;
 }