ASoC: wm8960: harmless underflow in wm8960_put_deemph()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Oct 2015 07:09:19 +0000 (10:09 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 22 Oct 2015 12:55:50 +0000 (13:55 +0100)
We should only accept "deemph" values of zero and one, but by mistake we
accept negatives as well.  It's harmless but let's clean it up anyway.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8960.c

index e3b7d0c..dc47c2f 100644 (file)
@@ -201,7 +201,7 @@ static int wm8960_put_deemph(struct snd_kcontrol *kcontrol,
 {
        struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
        struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
-       int deemph = ucontrol->value.integer.value[0];
+       unsigned int deemph = ucontrol->value.integer.value[0];
 
        if (deemph > 1)
                return -EINVAL;