xfs: fix scrub flagging rtinherit even if there is no rt device
authorDarrick J. Wong <darrick.wong@oracle.com>
Tue, 3 Nov 2020 01:14:07 +0000 (17:14 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 4 Nov 2020 16:52:47 +0000 (08:52 -0800)
The kernel has always allowed directories to have the rtinherit flag
set, even if there is no rt device, so this check is wrong.

Fixes: 80e4e1268802 ("xfs: scrub inodes")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/scrub/inode.c

index 3aa85b6..bb25ff1 100644 (file)
@@ -121,8 +121,7 @@ xchk_inode_flags(
                goto bad;
 
        /* rt flags require rt device */
-       if ((flags & (XFS_DIFLAG_REALTIME | XFS_DIFLAG_RTINHERIT)) &&
-           !mp->m_rtdev_targp)
+       if ((flags & XFS_DIFLAG_REALTIME) && !mp->m_rtdev_targp)
                goto bad;
 
        /* new rt bitmap flag only valid for rbmino */