platform/x86: fujitsu-laptop: sanitize hotkey input device identification
authorMichał Kępień <kernel@kempniu.pl>
Fri, 16 Jun 2017 04:40:55 +0000 (06:40 +0200)
committerDarren Hart (VMware) <dvhart@infradead.org>
Sat, 1 Jul 2017 03:13:04 +0000 (20:13 -0700)
In the case of brightness-related FUJ02B1 ACPI device, initializing the
input device associated with it identically as acpi-video initializes
its input device makes sense.  However, using the same data for the
input device associated with the FUJ02E3 ACPI device makes little sense,
because the latter has nothing to do with video and assigning an
arbitrary product ID to it is redundant.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/fujitsu-laptop.c

index b4e7a93..c01b8ed 100644 (file)
@@ -557,13 +557,12 @@ static int acpi_fujitsu_laptop_input_setup(struct acpi_device *device)
        if (!priv->input)
                return -ENOMEM;
 
-       snprintf(priv->phys, sizeof(priv->phys), "%s/video/input0",
+       snprintf(priv->phys, sizeof(priv->phys), "%s/input0",
                 acpi_device_hid(device));
 
        priv->input->name = acpi_device_name(device);
        priv->input->phys = priv->phys;
        priv->input->id.bustype = BUS_HOST;
-       priv->input->id.product = 0x06;
 
        dmi_check_system(fujitsu_laptop_dmi_table);
        ret = sparse_keymap_setup(priv->input, keymap, NULL);