media: atomisp: fix memleak in ia_css_stream_create
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Fri, 21 Aug 2020 05:49:16 +0000 (07:49 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 3 Sep 2020 09:01:56 +0000 (11:01 +0200)
When aspect_ratio_crop_init() fails, curr_stream needs
to be freed just like what we've done in the following
error paths. However, current code is returning directly
and ends up leaking memory.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/sh_css.c

index 54434c2..8473e14 100644 (file)
@@ -9521,7 +9521,7 @@ ia_css_stream_create(const struct ia_css_stream_config *stream_config,
        if (err)
        {
                IA_CSS_LEAVE_ERR(err);
-               return err;
+               goto ERR;
        }
 #endif
        for (i = 0; i < num_pipes; i++)