radv: re-enable DCC with mipmaps on GFX11
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Wed, 27 Sep 2023 15:20:01 +0000 (17:20 +0200)
committerMarge Bot <emma+marge@anholt.net>
Fri, 29 Sep 2023 06:54:42 +0000 (06:54 +0000)
This is now fixed.

Hi-Fi Rush, Sonic Frontiers and Hogwarts Legacy were known broken games.

I personally reproduced the issue with Hi-Fi Rush which has been fixed
since e6735409eef ("radv: disable DCC with signedness reinterpretation
on GFX11"). I also tested Sonic Frontiers which has been fixed since
52b68869922 ("amd: update addrlib"). I didn't check Hogwarts Legacy but
I think it was also fixed by e6735409eef.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25435>

src/amd/vulkan/radv_image.c

index e069275..1fedc8d 100644 (file)
@@ -277,10 +277,6 @@ radv_use_dcc_for_image_early(struct radv_device *device, struct radv_image *imag
    if (pCreateInfo->samples > 1 && !device->physical_device->use_fmask)
       return false;
 
-   /* FIXME: DCC with mipmaps is broken on GFX11. */
-   if (device->physical_device->rad_info.gfx_level == GFX11 && pCreateInfo->mipLevels > 1)
-      return false;
-
    return radv_are_formats_dcc_compatible(device->physical_device, pCreateInfo->pNext, format, pCreateInfo->flags,
                                           sign_reinterpret);
 }