s390/3270: fix missing device_destroy() call
authorHendrik Brueckner <brueckner@linux.vnet.ibm.com>
Tue, 12 Nov 2013 14:03:37 +0000 (15:03 +0100)
committerJiri Slaby <jslaby@suse.cz>
Wed, 12 Mar 2014 08:39:40 +0000 (09:39 +0100)
commit d1e61fe49fd450be15d402ac353784f5ba8a624e upstream.

Unloading the fs3270 kernel module does not remove the created
"3270/tub" device.  Reloading the module then causes a sysfs warning:
"sysfs: cannot create duplicate filename '/devices/virtual/3270/3270!tub'".

Call device_destroy() in the module exit function to solve this issue.

Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/s390/char/fs3270.c

index f93cc32eb81871b468c3439ecb03de5c19783710..71e9747380149d627a92883b2d17bd269c9f7817 100644 (file)
@@ -564,6 +564,7 @@ static void __exit
 fs3270_exit(void)
 {
        raw3270_unregister_notifier(&fs3270_notifier);
+       device_destroy(class3270, MKDEV(IBM_FS3270_MAJOR, 0));
        __unregister_chrdev(IBM_FS3270_MAJOR, 0, 1, "fs3270");
 }