projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dc9be0f
)
kvm: x86: i8259: return initialized data on invalid-size read
author
Petr Matousek
<pmatouse@redhat.com>
Wed, 11 Mar 2015 11:16:09 +0000
(12:16 +0100)
committer
Marcelo Tosatti
<mtosatti@redhat.com>
Fri, 13 Mar 2015 01:02:46 +0000
(22:02 -0300)
If data is read from PIC with invalid access size, the return data stays
uninitialized even though success is returned.
Fix this by always initializing the data.
Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Nadav Amit <nadav.amit@gmail.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
arch/x86/kvm/i8259.c
patch
|
blob
|
history
diff --git
a/arch/x86/kvm/i8259.c
b/arch/x86/kvm/i8259.c
index
cc31f7c
..
9541ba3
100644
(file)
--- a/
arch/x86/kvm/i8259.c
+++ b/
arch/x86/kvm/i8259.c
@@
-507,6
+507,7
@@
static int picdev_read(struct kvm_pic *s,
return -EOPNOTSUPP;
if (len != 1) {
+ memset(val, 0, len);
pr_pic_unimpl("non byte read\n");
return 0;
}