Modify expectation flow for unsigned char pointer test

Change-Id: I61f11b8991cbfe931f0b2205d297ab29578cedab

diff --git a/tests/serialization-test.cpp b/tests/serialization-test.cpp
index 852c28ed4302b422776bfd52ca9af34f50fd64cc..e9248b15d8fad97f78542d0c80c0f082d68e6599 100644 (file)
--- a/tests/serialization-test.cpp
+++ b/tests/serialization-test.cpp
@@ -327,15 +327,15 @@ void __testUnsignedCharPtr(unsigned char *data, size_t data_size)
     WAuthnCtypeSerializer::deserialize(buffer, &deserialized, &deserialized_len);
 
     EXPECT_EQ(data_size, deserialized_len);
-    EXPECT_EQ(memcmp(data, deserialized, deserialized_len), 0);
-    if (deserialized == nullptr || deserialized_len == 0) {
-        EXPECT_EQ(deserialized, nullptr);
-        EXPECT_EQ(deserialized_len, 0);
+    if (deserialized_len != 0) { // If deserialized_len is zero, memcmp is guaranteed to return zero
+        EXPECT_EQ(memcmp(data, deserialized, deserialized_len), 0);
     }
-    if (data == nullptr) {
+    else {
+        EXPECT_EQ(data, nullptr);
         EXPECT_EQ(deserialized, nullptr);
     }
 }
+
 TEST_F(WAuthnSerializationTest, unsignedCharPtr_P)
 {
     unsigned char data[13] = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,};