i40e: Remove EMPR traces from debugfs facility
authorMauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
Tue, 6 Aug 2019 13:38:26 +0000 (10:38 -0300)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 9 Sep 2019 18:36:43 +0000 (11:36 -0700)
Since commit
'5098850c9b9b ("i40e/i40evf: i40e_register.h updates")'
it is no longer possible to trigger an EMP Reset from debugfs, but it's
possible to request it either way, to end up with a bad reset request:

echo empr > /sys/kernel/debug/i40e/0002\:01\:00.1/command
i40e 0002:01:00.1: debugfs: forcing EMPR
i40e 0002:01:00.1: bad reset request 0x00010000

So let's remove this piece of code and show the available valid commands
as it is when any invalid command is issued.

Signed-off-by: "Mauro S. M. Rodrigues" <maurosr@linux.vnet.ibm.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e.h
drivers/net/ethernet/intel/i40e/i40e_debugfs.c

index 3e535d3..f1a1bd3 100644 (file)
@@ -131,7 +131,6 @@ enum i40e_state_t {
        __I40E_PF_RESET_REQUESTED,
        __I40E_CORE_RESET_REQUESTED,
        __I40E_GLOBAL_RESET_REQUESTED,
-       __I40E_EMP_RESET_REQUESTED,
        __I40E_EMP_RESET_INTR_RECEIVED,
        __I40E_SUSPENDED,
        __I40E_PTP_TX_IN_PROGRESS,
index 4123289..99ea543 100644 (file)
@@ -1125,10 +1125,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
                dev_info(&pf->pdev->dev, "debugfs: forcing GlobR\n");
                i40e_do_reset_safe(pf, BIT(__I40E_GLOBAL_RESET_REQUESTED));
 
-       } else if (strncmp(cmd_buf, "empr", 4) == 0) {
-               dev_info(&pf->pdev->dev, "debugfs: forcing EMPR\n");
-               i40e_do_reset_safe(pf, BIT(__I40E_EMP_RESET_REQUESTED));
-
        } else if (strncmp(cmd_buf, "read", 4) == 0) {
                u32 address;
                u32 value;